-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google's new "portal" element #220
Comments
Yeah I saw that as well... 😤😅 I think there's two things we could do:
|
I also think since this is still behind a flag in canary and only in chrome, there is time to warn people about this. |
Sure. A new major would be required once this becomes standard though |
@LinusBorg you could prep people with a new element name (i.e. function install(Vue: VueConstructor<Vue>, options: PluginOptions = {}) {
Vue.component(options.portalName || 'PortalSource', Portal)
Vue.component(options.portalName || 'Portal', Portal)
Vue.component(options.portalTargetName || 'PortalTarget', PortalTarget)
Vue.component(options.MountingPortalName || 'MountingPortal', MountingPortal)
}
// ...
export {
Portal,
Portal as PortalSource,
PortalTarget,
MountingPortal,
Wormhole
} |
Good idea! |
And then in a major release, drop the older deprecated |
So, I saw this from i/o 2019 yesterday, and figured i'd go ahead and raise the issue here.
https://web.dev/hands-on-portals/
it looks like google is wanting to create a
<portal>
standard for linking between pages.Would it be helpful to update the docs and examples to use
portal-vue
as the component name in anticipation of google trying to push this through?The text was updated successfully, but these errors were encountered: