Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -<VERSION> suffix from name of checks in PRs #5581

Open
3 tasks
romaricpascal opened this issue Jan 6, 2025 · 0 comments
Open
3 tasks

Remove -<VERSION> suffix from name of checks in PRs #5581

romaricpascal opened this issue Jan 6, 2025 · 0 comments

Comments

@romaricpascal
Copy link
Member

What

Remove the -<VERSION> (the -22.04 of ubunu-22.04 or -latest of windows-latest) from the name of the various checks that run when a PR is raised, especially those that are required checks.

Why

Until we run checks against multiple versions of the same OS, the only relevant information to us is the OS. Having the version in the name gets in the way of changing the version we run against, like we recently had to when our tests had issues with ubuntu-latest and we had to downgrade to ubuntu-22.04. This required us to update the required checks in the repository's settings, which is extra admin that only listing the OS name would avoid.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Checks on the govuk-frontend repository only have the OS in their name
  • Checks on the govuk-design-system repository only have the OS in their name
  • Checks on the govuk-frontend-docs repository only have the OS in their name (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant