Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable AltJits build for LoongArch64 and RiscV64 #110282

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Enable AltJits build for LoongArch64 and RiscV64 #110282

wants to merge 9 commits into from
+81 −47

Conversation

hez2010
Copy link
Contributor

@hez2010 hez2010 commented Nov 30, 2024 •
edited
Loading

...so that

  • Any changes lead to build failure can be observed
  • Being able to inspect codegen using crossgen2 on other platforms

Introduced a new subset Clr.AllJitsCommunity

Closes #97712

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 30, 2024
@hez2010
Copy link
Contributor Author

hez2010 commented Nov 30, 2024

Build is passing. Now I'm going to work on the new build subset.

@build-analysis build-analysis bot mentioned this pull request Nov 30, 2024
Open
3 tasks
@MichalPetryka
Copy link
Contributor

This should be marked as closing #97712.

@jkotas jkotas added arch-riscv Related to the RISC-V architecture arch-loongarch64 labels Nov 30, 2024
@huoyaoyuan
Copy link
Member

Seems that this will also be included in the default build clr? Building altjit is already taking a significant portion of time.

@hez2010
Copy link
Contributor Author

hez2010 commented Nov 30, 2024

Seems that this will also be included in the default build clr? Building altjit is already taking a significant portion of time.

That's why there's a TODO in the PR description.

xen0n pushed a commit to loongson-community/dotnet that referenced this pull request Dec 4, 2024
@hez2010 @xen0n
Build LoongArch64 and RiscV64 AltJit
3b38f36 
[dotnet-unofficial-build]: squash of dotnet/runtime#110282
xen0n pushed a commit to loongson-community/dotnet that referenced this pull request Dec 5, 2024
@hez2010 @xen0n
Build LoongArch64 and RiscV64 AltJit
741667d 
[dotnet-unofficial-build]: squash of dotnet/runtime#110282
@hez2010
Copy link
Contributor Author

hez2010 commented Dec 5, 2024 •
edited
Loading

Introduced a new subset Clr.AllJitsCommunity. Now it's ready for merge.
@jakobbotsch Please take a look.

This was referenced Dec 5, 2024
Open
Open
Closed
Closed
Open
@JulieLeeMSFT
Copy link
Member

@jakobbotsch, PTAL.

@huoyaoyuan
Copy link
Member

Since we are having CI legs for LA64 and RV, including these in the CI (and default build) seems unnecessary now.

@hez2010
Copy link
Contributor Author

hez2010 commented Jan 10, 2025

Since we are having CI legs for LA64 and RV, including these in the CI (and default build) seems unnecessary now.

We still need this because this will be used to enable LA64/RV64 altjits on godbolt so that we can inspect the codegen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotas jkotas jkotas left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jakobbotsch jakobbotsch

@hez2010 hez2010

Labels
arch-loongarch64 arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide subsets for AltJits for RISC-V and LoongArch64
6 participants
@hez2010 @MichalPetryka @huoyaoyuan @JulieLeeMSFT @jkotas @jakobbotsch