Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL switched to "noble" causing SCons to not function anymore. #18421

Open
LordOfDragons opened this issue Jan 7, 2025 · 6 comments
Open
Labels
question Further information is requested

Comments

@LordOfDragons
Copy link

See build failure here: https://github.com/LordOfDragons/denetwork/actions/runs/12642338845/job/35226440472 .
Previous builds ran on "jammy" (like here: https://github.com/LordOfDragons/denetwork/actions/runs/12168781129/job/33940270968). In these builds SCons could be run without a problem. In the upgrade to noble "SCons" got lost and the builds fail.

Request: Add back SCons to the "noble" build image as it has been the case in the "jammy" build image.

@LordOfDragons LordOfDragons added the question Further information is requested label Jan 7, 2025
@aibaars
Copy link
Contributor

aibaars commented Jan 7, 2025

That's unfortunate. As you can see there was a warning at https://github.com/LordOfDragons/denetwork/actions/runs/12168781129/job/33940270968


ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see actions/runner-images#10636
--


I'm not sure why scons cannot be found in the new image. Perhaps it was removed. However, even if it isn't present in the image, I would have expected the C++ automatic installation of dependencies feature to automatically install it.

If the scons tool was present by default in the old ubuntu-latest image, then you best file an issue at https://github.com/actions/runner-images asking if it can be put back.

I'll also ask the CodeQL team to look into why scons isn't installed automatically.

@LordOfDragons
Copy link
Author

LordOfDragons commented Jan 7, 2025

In that case it is the CodeQL dependency installation that is the problem. In the docker images used for regular building jobs (noble, jammy) SCons package is not pre-installed and I have to manually install them. I thought CodeQL uses different docker images since in jammy it just worked.

@aibaars
Copy link
Contributor

aibaars commented Jan 7, 2025

It turns out that CodeQL was missing a package index for noble. This should be fixed in the next release which I expect this week or the next.

@LordOfDragons
Copy link
Author

Sounds good to me. Can you ping me when it's ready? Then I can give it a test.

@aibaars
Copy link
Contributor

aibaars commented Jan 8, 2025

Sounds good to me. Can you ping me when it's ready? Then I can give it a test.

The pre-release can be found here: https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.20.1 . You can use the tools: property of github/codeql-action/init and set it to the URL of a release artifact.

@LordOfDragons
Copy link
Author

That repo uses simple mode of CodeQL so I guess I can only test the release version :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants