Adds REQUIRED_ARGUMENT_MISSING_IN_SOME_SCHEMA
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glen-84
suggested changes
Jan 2, 2025
Co-authored-by: Glen <[email protected]>
Co-authored-by: Glen <[email protected]>
Co-authored-by: Glen <[email protected]>
glen-84
reviewed
Jan 9, 2025
|
|
||
| **Error Code:** | ||
|
|
||
| `REQUIRED_ARGUMENT_MISSING_IN_SOME_SCHEMA` |
There was a problem hiding this comment.
Could we try to keep the error codes <~35 characters?
There was a problem hiding this comment.
Maybe REQUIRED_FIELD_ARGUMENT_MISSING?
glen-84
suggested changes
Jan 9, 2025
|
|
||
| **Error Code:** | ||
|
|
||
| `REQUIRED_ARGUMENT_MISSING_IN_SOME_SCHEMA` |
There was a problem hiding this comment.
Maybe REQUIRED_FIELD_ARGUMENT_MISSING?
|
|
||
| **Formal Specification:** | ||
|
|
||
| - Let {typeNames} be the set of all object and interface types names from all |
There was a problem hiding this comment.
Suggested change
| - Let {typeNames} be the set of all object and interface types names from all | |
| - Let {typeNames} be the set of all object and interface type names from all |
|
|
||
| When merging a field definition across multiple schemas, any argument that is | ||
| non-null (i.e., “required”) in one schema must appear in all schemas that define | ||
| that field . In other words, arguments are effectively merged by intersection: |
There was a problem hiding this comment.
Suggested change
| that field . In other words, arguments are effectively merged by intersection: | |
| that field. In other words, arguments are effectively merged by intersection: |
| if an argument is considered required in any schema, then that same argument | ||
| must exist in every schema that contributes to the composite definition. If a | ||
| required argument is missing in one schema, there is no consistent way to define | ||
| that field or directive across schemas. |
There was a problem hiding this comment.
The spec doesn't mention directive arguments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.