Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Performance.{mark, measure} #2148

Open
jasonwilliams opened this issue Dec 13, 2024 · 1 comment
Open

Support for Performance.{mark, measure} #2148

jasonwilliams opened this issue Dec 13, 2024 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality

Comments

@jasonwilliams
Copy link
Contributor

This may be a limitation of Node.js rather than VS Code, but it would be good to have performance.mark and performance.measure annoations appear in the final trace and the flamegraph you get after profiling. Sometimes I add more detailed measures around unnamed anonymous functions to get a idea on how long it took, but then I can't see the results inside of flamegraph.

This works in the browser using dev tools but it doesn't seem to exist from the VS Code side. Here is the browser version explained:
https://developer.chrome.com/docs/devtools/performance/reference

Image

What is needed for this support to appear in the VS Code profile output and flamegraph?

@jasonwilliams jasonwilliams added the feature-request Request for new features or functionality label Dec 13, 2024
@connor4312
Copy link
Member

connor4312 commented Dec 13, 2024

Currently our profiles come from the Profiler V8 domain. Marks appear on the PerformanceTimeline which is not something we interact with yet, so implementing this is not super trivial. I also don't know whether Node.js implements that domain as it's not part of the v8-inspector protocol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants