Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some references.view shortcuts not working #234017

Open
ckx opened this issue Nov 17, 2024 · 2 comments · May be fixed by #237486
Open

Some references.view shortcuts not working #234017

ckx opened this issue Nov 17, 2024 · 2 comments · May be fixed by #237486
Assignees
Labels
feature-request Request for new features or functionality references-viewlet

Comments

@ckx
Copy link

ckx commented Nov 17, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.95.3
  • OS Version: Fedora 41

Steps to Reproduce:

  1. Open the Keyboard Shortcuts preferences window.
  2. Attempt to bind references-view.removeReferenceItem (Dismiss) to a keybinding
  3. Right click some field or other code construct, click "Find All References."
  4. Press references-view.removeReferenceItem keybind.
  5. The keybinding does not work.

Expected behavior:

I'd expect this keybinding to execute "Dismiss" on the currently selected reference item, similar to when you right click -> Dismiss in the reference view.

Other info:

  • I have tested various keybindings, ensured no clashing keybindings, restarted vscode, and messed with the "when" conditionals quite a bit.
  • I cannot get references-view.removeReferencesItem, references-view.removeCallItem or references-view.removeTypeItem to do anything regardless of my keybinding or editor state.
  • I can't get references-view.refind to work either.
  • references-view.next, references-view.previous, and references-view.findReferences work fine (and are very handy!)
  • I installed latest VS Code in a Windows 11 VM and tested there with the exact same results.

Am I doing something wrong? I'm real interested in those removeReferences bindings but I just can't get them to do anything for the life of me.

Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@ckx
Copy link
Author

ckx commented Dec 10, 2024

This response confuses me a bit. I suppose the implication is that the functionality was never implemented, but has unmarked placeholder entries in the UI?

EDIT: Dug up another issue where the same thing happened. #200465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality references-viewlet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants