Several color defaults that "need transparency" are opaque

[andrewsuzuki]

• minimap.findMatchHighlight (all)
• minimap.selectionOccurrenceHighlight (all)
• minimap.selectionHighlight (all)
  • also opaque in a few built-in themes: Red, Quiet Light, Abyss, etc
• terminal.findMatchBackground (dark, light, hcLight) (dark and light refer to editor.findMatchBackground)
• editorOverviewRuler.findMatchForeground (hcDark, hcLight)

vscode/src/vs/platform/theme/common/colors/minimapColors.ts

Lines 17 to 27 in 0fed760

	export const minimapFindMatch = registerColor('minimap.findMatchHighlight',
	{ light: '#d18616', dark: '#d18616', hcDark: '#AB5A00', hcLight: '#0F4A85' },
	nls.localize('minimapFindMatchHighlight', 'Minimap marker color for find matches.'), true);
	export const minimapSelectionOccurrenceHighlight = registerColor('minimap.selectionOccurrenceHighlight',
	{ light: '#c9c9c9', dark: '#676767', hcDark: '#ffffff', hcLight: '#0F4A85' },
	nls.localize('minimapSelectionOccurrenceHighlight', 'Minimap marker color for repeating editor selections.'), true);
	export const minimapSelection = registerColor('minimap.selectionHighlight',
	{ light: '#ADD6FF', dark: '#264F78', hcDark: '#ffffff', hcLight: '#0F4A85' },
	nls.localize('minimapSelectionHighlight', 'Minimap marker color for the editor selection.'), true);

vscode/src/vs/workbench/contrib/terminal/common/terminalColorRegistry.ts

Lines 61 to 67 in 0fed760

	export const TERMINAL_FIND_MATCH_BACKGROUND_COLOR = registerColor('terminal.findMatchBackground', {
	dark: editorFindMatch,
	light: editorFindMatch,
	// Use regular selection background in high contrast with a thick border
	hcDark: null,
	hcLight: '#0F4A85'
	}, nls.localize('terminal.findMatchBackground', 'Color of the current search match in the terminal. The color must not be opaque so as not to hide underlying terminal content.'), true);

vscode/src/vs/platform/theme/common/colors/editorColors.ts

Lines 432 to 434 in 0fed760

	export const overviewRulerFindMatchForeground = registerColor('editorOverviewRuler.findMatchForeground',
	{ dark: '#d186167e', light: '#d186167e', hcDark: '#AB5A00', hcLight: '#AB5A00' },
	nls.localize('overviewRulerFindMatchForeground', 'Overview ruler marker color for find matches. The color must not be opaque so as not to hide underlying decorations.'), true);