Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json] Colorisation of JSON in VSC breaks part way down the file #10338

Closed
snicholson13 opened this issue Aug 9, 2016 · 8 comments · May be fixed by #237513
Closed

[json] Colorisation of JSON in VSC breaks part way down the file #10338

snicholson13 opened this issue Aug 9, 2016 · 8 comments · May be fixed by #237513
Assignees
Labels
info-needed Issue requires more information from poster json JSON support issues

Comments

@snicholson13
Copy link

  • VSCode Version: 1.4.0
  • OS Version: Windows 8.1 enterprise

Issue:

  1. There was an update for my VSC on 8th August 2016 - the date in the about information says 2016-08-04, post this update the colorisation stops part way down the file
  2. A JSON file of 6076 lines, the colour stops at line 1242
  3. A JSON file of 2628 lines, colour stops at line 1777
@aeschli
Copy link
Contributor

aeschli commented Aug 9, 2016

Can you attach the JSON file?

@snicholson13
Copy link
Author

Hi Martin

Thank you for coming back to me. Unfortunately I am not allowed to upload the file for confidentiality reasons. I have been working on the same files for the last couple of months and the colourisation has always been fine

Sarah | BA | 02037 579 019
[email protected]:[email protected]

From: Martin Aeschlimann [mailto:[email protected]]
Sent: 09 August 2016 11:13
To: Microsoft/vscode [email protected]
Cc: Sarah Nicholson [email protected]; Author [email protected]
Subject: Re: [Microsoft/vscode] Colorisation of JSON in VSC breaks part way down the file (#10338)

Can you attach the JSON file?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/10338#issuecomment-238511405, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AT9FmDoNUedg9Nkx53uhYwxxrtO_8ohxks5qeFK5gaJpZM4Jf3L5.

@aeschli
Copy link
Contributor

aeschli commented Aug 15, 2016

I tried to reproduce this with a huge file of JSON, but wasn't able to.
Any chance you can create a sample that does?
Anything special in your file? Comments? Numbers on interesting formats, escapes in strings? Deep object structures?

@aeschli aeschli changed the title Colorisation of JSON in VSC breaks part way down the file [json] Colorisation of JSON in VSC breaks part way down the file Aug 15, 2016
@aeschli aeschli added json JSON support issues info-needed Issue requires more information from poster labels Aug 15, 2016
@snicholson13
Copy link
Author

Hi

I have very deep object structures and a tiny bit of HTML (only
). I don’t think there is anything else special about it?
I will try to create a sample file for you but it might not be today.

Sarah | BA | 02037 579 019
[email protected]:[email protected]

From: Martin Aeschlimann [mailto:[email protected]]
Sent: 15 August 2016 11:37
To: Microsoft/vscode [email protected]
Cc: Sarah Nicholson [email protected]; Author [email protected]
Subject: Re: [Microsoft/vscode] Colorisation of JSON in VSC breaks part way down the file (#10338)

I tried to reproduce this with a huge file of JSON, but wasn't able to.
Any chance you can create a sample that does?
Anything special in your file? Comments? Numbers on interesting formats, escapes in strings? Deep object structures?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/10338#issuecomment-239774024, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AT9FmMtI35sb464w01ucxF1bG1_jol3hks5qgEFQgaJpZM4Jf3L5.

@snicholson13
Copy link
Author

The colour is going at line 243 in my VSC

Sarah | BA | 02037 579 019
[email protected]:[email protected]

From: Sarah Nicholson
Sent: 15 August 2016 14:11
To: Microsoft/vscode [email protected]; Microsoft/vscode [email protected]
Cc: Author [email protected]
Subject: RE: [Microsoft/vscode] Colorisation of JSON in VSC breaks part way down the file (#10338)

Hi

I have very deep object structures and a tiny bit of HTML (only
). I don’t think there is anything else special about it?
I will try to create a sample file for you but it might not be today.

Sarah | BA | 02037 579 019
[email protected]:[email protected]

From: Martin Aeschlimann [mailto:[email protected]]
Sent: 15 August 2016 11:37
To: Microsoft/vscode <[email protected]mailto:[email protected]>
Cc: Sarah Nicholson <[email protected]mailto:[email protected]>; Author <[email protected]mailto:[email protected]>
Subject: Re: [Microsoft/vscode] Colorisation of JSON in VSC breaks part way down the file (#10338)

I tried to reproduce this with a huge file of JSON, but wasn't able to.
Any chance you can create a sample that does?
Anything special in your file? Comments? Numbers on interesting formats, escapes in strings? Deep object structures?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/10338#issuecomment-239774024, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AT9FmMtI35sb464w01ucxF1bG1_jol3hks5qgEFQgaJpZM4Jf3L5.

@aeschli
Copy link
Contributor

aeschli commented Aug 29, 2016

@snicholson13 I'd still need a reproducible example.
Do you have a 30 objects nested in each other? That would explain it. It would be the same issue as #9937

@aeschli
Copy link
Contributor

aeschli commented Aug 30, 2016

Closing as dup of #9937

@aeschli aeschli closed this as completed Aug 30, 2016
@snicholson13
Copy link
Author

Hi Martin

I see you closed this. I don’t think my file is 30 deep. I have reinstalled an older version so this bug goes away for now

Sarah | BA | 02037 579 019
[email protected]:[email protected]

From: Sarah Nicholson
Sent: 16 August 2016 15:42
To: 'Microsoft/vscode' [email protected]; 'Microsoft/vscode' [email protected]
Cc: 'Author' [email protected]
Subject: RE: [Microsoft/vscode] Colorisation of JSON in VSC breaks part way down the file (#10338)

The colour is going at line 243 in my VSC

Sarah | BA | 02037 579 019
[email protected]:[email protected]

From: Sarah Nicholson
Sent: 15 August 2016 14:11
To: Microsoft/vscode [email protected]; Microsoft/vscode <[email protected]mailto:[email protected]>
Cc: Author <[email protected]mailto:[email protected]>
Subject: RE: [Microsoft/vscode] Colorisation of JSON in VSC breaks part way down the file (#10338)

Hi

I have very deep object structures and a tiny bit of HTML (only
). I don’t think there is anything else special about it?
I will try to create a sample file for you but it might not be today.

Sarah | BA | 02037 579 019
[email protected]:[email protected]

From: Martin Aeschlimann [mailto:[email protected]]
Sent: 15 August 2016 11:37
To: Microsoft/vscode <[email protected]mailto:[email protected]>
Cc: Sarah Nicholson <[email protected]mailto:[email protected]>; Author <[email protected]mailto:[email protected]>
Subject: Re: [Microsoft/vscode] Colorisation of JSON in VSC breaks part way down the file (#10338)

I tried to reproduce this with a huge file of JSON, but wasn't able to.
Any chance you can create a sample that does?
Anything special in your file? Comments? Numbers on interesting formats, escapes in strings? Deep object structures?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/10338#issuecomment-239774024, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AT9FmMtI35sb464w01ucxF1bG1_jol3hks5qgEFQgaJpZM4Jf3L5.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
meganrogge added a commit that referenced this issue Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster json JSON support issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants