Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for jsonrpc4j #6020

Open
breedx-splk opened this issue May 12, 2022 · 2 comments · May be fixed by #13008
Open

Add support for jsonrpc4j #6020

breedx-splk opened this issue May 12, 2022 · 2 comments · May be fixed by #13008
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request new instrumentation

Comments

@breedx-splk
Copy link
Contributor

It would be great to have instrumentation for https://github.com/briandilley/jsonrpc4j.

The matching could get a little interesting, because this library includes support for:

  • client
  • server
  • spring remoting
  • dynamic proxies
  • spring + annotation-based autodiscovery

We could definitely start small with just server and then add additional issues to support client and then others (as it makes sense to).
@breedx-splk breedx-splk added the enhancement New feature or request label May 12, 2022
@trask
Copy link
Member

trask commented May 12, 2022

linking in related(?) issue #5995

@mateuszrzeszutek mateuszrzeszutek added contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome new instrumentation labels May 13, 2022
@chenlujjj
Copy link

Hi @trask , I am working on it, I'd like to create a PR in the near future, maybe next week

@chenlujjj chenlujjj linked a pull request Jan 7, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request new instrumentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support instrumentation for jsonrpc4j chenlujjj/opentelemetry-java-instrumentation
4 participants
@trask @chenlujjj @mateuszrzeszutek @breedx-splk