Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add datadog-thin-str crate #2994

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

morrisonlevi
Copy link
Collaborator

It doesn't yet update profiling to use it. Splitting into multiple PRs for it to be easier to review.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.80%. Comparing base (94538cb) to head (2d12753).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2994      +/-   ##
============================================
+ Coverage     72.78%   74.80%   +2.02%     
  Complexity     2781     2781              
============================================
  Files           139      112      -27     
  Lines         15166    11017    -4149     
  Branches       1022        0    -1022     
============================================
- Hits          11038     8241    -2797     
+ Misses         3576     2776     -800     
+ Partials        552        0     -552     
Flag Coverage Δ
appsec-extension ?
tracer-php 74.80% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94538cb...2d12753. Read the comment docs.

@morrisonlevi morrisonlevi force-pushed the levi/thin-str branch 3 times, most recently from a67258b to 4ed5a94 Compare December 19, 2024 21:46
@morrisonlevi morrisonlevi force-pushed the levi/thin-str branch 2 times, most recently from 23476b8 to f38e49e Compare January 6, 2025 16:44
It doesn't yet update profiling to use it. Splitting into multiple
PRs for it to be easier to review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants