Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageSharp v4 compatibility #351

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

ImageSharp v4 is starting to become more stable now so it's a good time to migrate and switch focus to ImageSharp.Drawing v3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 38 out of 53 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • .editorconfig: Language not supported
  • .gitattributes: Language not supported
  • .github/workflows/build-and-test.yml: Language not supported
  • samples/DrawShapesWithImageSharp/DrawShapesWithImageSharp.csproj: Language not supported
  • shared-infrastructure: Language not supported
  • src/ImageSharp.Drawing/ImageSharp.Drawing.csproj: Language not supported
  • tests/Directory.Build.targets: Language not supported
  • tests/ImageSharp.Drawing.Benchmarks/ImageSharp.Drawing.Benchmarks.csproj: Language not supported
  • src/ImageSharp.Drawing/Common/Extensions/GraphicsOptionsExtensions.cs: Evaluated as low risk
  • src/ImageSharp.Drawing/Processing/RecolorBrush.cs: Evaluated as low risk
  • src/ImageSharp.Drawing/Processing/PathGradientBrush.cs: Evaluated as low risk
  • src/ImageSharp.Drawing/Processing/Processors/Text/RichTextGlyphRenderer.cs: Evaluated as low risk
  • src/ImageSharp.Drawing/Processing/PatternBrush.cs: Evaluated as low risk
  • tests/ImageSharp.Drawing.Tests/ConfigurationTests.cs: Evaluated as low risk
  • src/ImageSharp.Drawing/Processing/GradientBrush.cs: Evaluated as low risk
@tocsoft
Copy link
Member

tocsoft commented Jan 9, 2025

Should we think about maybe merging the ImageSharp and ImageSharp.Drawing Repos? as part of the v4 release cycle?

We originally split the repos because we where not ready to release a full release of Drawing in step with ImageSharp but as they are both now stable we could just merge the repos together... it'll make producing release much simpler as we won't need to do the dance releasing one then the other we have now.

It would also have some side benefits around issue and discussion management for the community as there would be a single repo for most things (Font specific issue withstanding).

If we do decide to merge repos then the follow up question might be should it be a single project/package or still live as 2 projects/packages but released in tandem?

@JimBobSquarePants
Copy link
Member Author

@tocsoft I would love to get them merged together. Currently there is a lot of work maintaining the separate libraries and the Drawing library has been neglected as a result of this extra work. There's experimental rasterization work I would like to get looked at properly for example.

My preference would be merging the entire codebase and releasing a single package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants