Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10300/3d06cc1][3.11] Use kwargs in aiohttp.client.request #10303

Open
wants to merge 1 commit into
base: 3.11
Choose a base branch
from

Conversation

Cycloctane
Copy link
Member

(cherry picked from commit 3d06cc1)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 6, 2025
Copy link

codspeed-hq bot commented Jan 6, 2025

CodSpeed Performance Report

Merging #10303 will improve performances by 9.14%

Comparing Cycloctane:patchback/backports/3.11/3d06cc14ad82ce4c207449b593955c23bd5e4d88/pr-10300 (2e73e1e) with 3.11 (0c32bc8)

Summary

⚡ 1 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark 3.11 Cycloctane:patchback/backports/3.11/3d06cc14ad82ce4c207449b593955c23bd5e4d88/pr-10300 Change
test_get_request_with_251308_compressed_chunked_payload[pyloop] 464.9 ms 426 ms +9.14%

@Cycloctane Cycloctane force-pushed the patchback/backports/3.11/3d06cc14ad82ce4c207449b593955c23bd5e4d88/pr-10300 branch from 9f09eb9 to 44f3710 Compare January 6, 2025 16:37
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.05%. Comparing base (0c32bc8) to head (44f3710).

Files with missing lines Patch % Lines
aiohttp/client.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             3.11   #10303      +/-   ##
==========================================
- Coverage   98.07%   98.05%   -0.02%     
==========================================
  Files         123      123              
  Lines       37219    37228       +9     
  Branches     4476     4477       +1     
==========================================
+ Hits        36501    36503       +2     
- Misses        540      544       +4     
- Partials      178      181       +3     
Flag Coverage Δ
CI-GHA 97.95% <93.75%> (-0.02%) ⬇️
OS-Linux 97.64% <93.75%> (-0.02%) ⬇️
OS-Windows 94.54% <93.75%> (-0.15%) ⬇️
OS-macOS 96.78% <93.75%> (+<0.01%) ⬆️
Py-3.10.11 96.63% <93.75%> (+<0.01%) ⬆️
Py-3.10.15 97.21% <93.75%> (+0.04%) ⬆️
Py-3.11.11 97.23% <93.75%> (-0.05%) ⬇️
Py-3.11.9 96.72% <93.75%> (+0.01%) ⬆️
Py-3.12.8 96.56% <93.75%> (-1.17%) ⬇️
Py-3.13.1 97.45% <93.75%> (-0.27%) ⬇️
Py-3.9.13 96.28% <93.75%> (-0.29%) ⬇️
Py-3.9.20 96.91% <93.75%> (-0.19%) ⬇️
Py-3.9.21 96.47% <93.75%> (?)
Py-pypy7.3.16 ?
VM-macos 96.78% <93.75%> (+<0.01%) ⬆️
VM-ubuntu 97.64% <93.75%> (-0.02%) ⬇️
VM-windows 94.54% <93.75%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cycloctane Cycloctane force-pushed the patchback/backports/3.11/3d06cc14ad82ce4c207449b593955c23bd5e4d88/pr-10300 branch from 44f3710 to 2e73e1e Compare January 7, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant