[WIP] Remove CallContextCatalogFactory #592
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
commented
Dec 26, 2024
| "/tmp/iceberg_rest_server_warehouse_data/"; | ||
|
|
||
| @Nonnull | ||
| protected Catalog createBasePolarisCatalog(Map<String, String> catalogProperties) { |
There was a problem hiding this comment.
Protected method, in case some tests need to override it (not the case at the moment).
adutra
force-pushed
the
remove-call-context-catalog-factory
branch
15 times, most recently
from
7b532f7 to
91f3ce3
Compare
adutra
force-pushed
the
remove-call-context-catalog-factory
branch
from
91f3ce3 to
29efd5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #469, #604 and #589.
This PR removes the
CallContextCatalogFactoryclass that becomes obsolete after the removal ofCallContext.