Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winch: implement atomic load operation for x64 #9954

Closed
wants to merge 0 commits into from

Conversation

MarinPostma
Copy link
Contributor

@MarinPostma MarinPostma commented Jan 9, 2025

this PR enable the thread feature for x64 in Winch, and implements atomic loads. This includes:

  • i32.atomic.load8_u
  • i32.atomic.load16_u
  • i32.atomic.load
  • i64.atomic.load8_u
  • i64.atomic.load16_u
  • i64.atomic.load32_u
  • i64.atomic.load

#9734

@MarinPostma MarinPostma requested review from a team as code owners January 9, 2025 15:36
@MarinPostma MarinPostma requested review from cfallin and alexcrichton and removed request for a team January 9, 2025 15:36
@alexcrichton alexcrichton requested review from saulecabrera and removed request for alexcrichton January 9, 2025 15:44
@MarinPostma MarinPostma force-pushed the main branch 2 times, most recently from 98d8899 to bc6b244 Compare January 9, 2025 15:52
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime winch Winch issues or pull requests labels Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Subscribe to Label Action

cc @saulecabrera

This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "winch"

Thus the following users have been cc'd because of the following labels:

  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link

github-actions bot commented Jan 9, 2025

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime winch Winch issues or pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant