Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable impl-trait-overcaptures 2024 transition lint #9965

Merged

Conversation

alexcrichton
Copy link
Member

This lint detects cases where returning impl Trait will work differently in 2024 than in the current 2021 edition. Ambiguities are resolved with use<..> syntax stabilized in Rust 1.82.0 to mean the same thing in both editions.

@alexcrichton alexcrichton requested review from a team as code owners January 9, 2025 19:32
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team January 9, 2025 19:32
This lint detects cases where returning `impl Trait` will work
differently in 2024 than in the current 2021 edition. Ambiguities are
resolved with `use<..>` syntax stabilized in Rust 1.82.0 to mean the
same thing in both editions.
@alexcrichton alexcrichton force-pushed the impl-trait-overcaptures branch from 37ca13d to 5543b86 Compare January 9, 2025 21:06
@alexcrichton alexcrichton enabled auto-merge January 9, 2025 21:06
@alexcrichton alexcrichton added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@alexcrichton alexcrichton enabled auto-merge January 9, 2025 21:34
@alexcrichton alexcrichton added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:meta Everything related to the meta-language. pulley Issues related to the Pulley interpreter wasi Issues pertaining to WASI wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:ref-types Issues related to reference types and GC in Wasmtime labels Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:meta", "pulley", "wasi", "wasmtime:api", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: pulley, wasmtime:ref-types

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton alexcrichton enabled auto-merge January 9, 2025 23:03
@alexcrichton alexcrichton added this pull request to the merge queue Jan 9, 2025
Merged via the queue into bytecodealliance:main with commit de1ad34 Jan 9, 2025
37 checks passed
@alexcrichton alexcrichton deleted the impl-trait-overcaptures branch January 9, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:meta Everything related to the meta-language. cranelift Issues related to the Cranelift code generator pulley Issues related to the Pulley interpreter wasi Issues pertaining to WASI wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:ref-types Issues related to reference types and GC in Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants