feat: Create plans and tiers tables #467
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
==========================================
- Coverage 90.55% 89.97% -0.58%
==========================================
Files 404 324 -80
Lines 12562 9198 -3364
Branches 2107 1633 -474
==========================================
- Hits 11375 8276 -3099
+ Misses 1078 859 -219
+ Partials 109 63 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
||
| class BillingRate(models.TextChoices): | ||
| MONTHLY = "monthly" | ||
| YEARLY = "yearly" |
There was a problem hiding this comment.
why not use PlanBillingRate?
There was a problem hiding this comment.
this should be annually instead of yearly as well I think https://github.com/codecov/gazebo/blob/113a97f9e6a40ab9162576599308e123a25626aa/src/shared/utils/billing.ts#L29
| tier = models.ForeignKey( | ||
| "Tiers", on_delete=models.CASCADE, related_name="plans", db_index=True | ||
| ) |
There was a problem hiding this comment.
| tier = models.ForeignKey( | |
| "Tiers", on_delete=models.CASCADE, related_name="plans", db_index=True | |
| ) | |
| tier = models.ForeignKey( | |
| "Tiers", on_delete=models.SET_NULL, related_name="plans" | |
| ) |
I removed the index, seems unnecessary for a small table, but up to you
There was a problem hiding this comment.
Agreed with Nora, probably don't need an index here
| tier = models.ForeignKey( | ||
| "Tiers", on_delete=models.CASCADE, related_name="plans", db_index=True | ||
| ) | ||
| base_unit_price = models.IntegerField(default=0) |
There was a problem hiding this comment.
| base_unit_price = models.IntegerField(default=0) | |
| base_unit_price = models.IntegerField(default=0, blank=True) |
There was a problem hiding this comment.
I think this one should always have a value, assuming blank=True means nullable
| plan_name = models.CharField(max_length=255, unique=True) | ||
|
|
||
| class Meta: | ||
| db_table = "plans" |
| private_repo_support = models.BooleanField(default=False) | ||
|
|
||
| class Meta: | ||
| db_table = "tiers" |
There was a problem hiding this comment.
prob not needed for a new table unless there's naming overlap with another table
There was a problem hiding this comment.
looking good! left some comments, happy to discuss any if you want :)
I think @ajay-sentry said that there will be a lot of django admin use of these tables - I would make those pages now and test them to make sure your fields are the way you want. Same with factories.
| max_seats = models.IntegerField(null=True, blank=True) | ||
| monthly_uploads_limit = models.IntegerField(null=True, blank=True) | ||
| paid_plan = models.BooleanField(default=False) | ||
| plan_name = models.CharField(max_length=255, unique=True) |
There was a problem hiding this comment.
just a thought here, should we just call this "name?" since it's already on the plan 🤔
| bundle_analysis = models.BooleanField(default=False) | ||
| test_analytics = models.BooleanField(default=False) | ||
| flaky_test_detection = models.BooleanField(default=False) | ||
| patch_coverage = models.BooleanField(default=False) |
There was a problem hiding this comment.
This should be project coverage right?
To replace plans representation, we're making plans configurable through the DB.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.