C#: Adding synthetic implicit ToString calls in binary expressions. #18446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/implicittostring2
branch
from
8616405 to
7ba7af1
Compare
michaelnebel
force-pushed
the
csharp/implicittostring2
branch
from
7ba7af1 to
9959976
Compare
michaelnebel
force-pushed
the
csharp/implicittostring2
branch
2 times, most recently
from
64a2912 to
b2712e0
Compare
…ring calls into account.
michaelnebel
force-pushed
the
csharp/implicittostring2
branch
from
b2712e0 to
ee23271
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we get the ball rolling on synthesizing compiler generated
ToStringcalls.As a start we introduce
ToStringcalls in binary expressions for concatenating strings.That is,
"abc" + x -> "abc" + x.ToString()