auth azure: support access token #3580
Conversation
LiliDeng
force-pushed
the
lildeng/fix_12_25_003
branch
2 times, most recently
from
d5117f1 to
6e9a2fb
Compare
|
During testing, found this token is working for managing azure resources, I am consulting azure python sdk how to handle this. |
What does it mean? Do you mean it fails in some scenarios, so you need have more tests or confirmation before merging? If so, please set it to Draft. |
LiliDeng
force-pushed
the
lildeng/fix_12_25_003
branch
2 times, most recently
from
be05158 to
f35f51f
Compare
Never mind, this one works. |
LiliDeng
force-pushed
the
lildeng/fix_12_25_003
branch
from
f35f51f to
e0d591e
Compare
LiliDeng
force-pushed
the
lildeng/fix_12_25_003
branch
from
e0d591e to
b7f2693
Compare
| @@ -1696,6 +1698,7 @@ def get_or_create_storage_container( | |||
| """ | |||
| Create a Azure Storage container if it does not exist. | |||
| """ | |||
| credential = get_static_access_token("AZURE_STORAGE_ACCESS_TOKEN") or credential | |||
There was a problem hiding this comment.
Why the env name variable is different? Is it defined by the staroge class or us?
There was a problem hiding this comment.
it is defined by us, the tokens need to be generated based on different scopes.
There was a problem hiding this comment.
- Is it possible to have one token with all scopes like *?
- Define schema to accept tokens, instead of env vars. All LISA vars should be defined in runbook.
Let me know, if it's hard to fulfill above.
There was a problem hiding this comment.
- I have confirmed with the maintainer of python sdk, he said we have to use different tokens for different scopes.
- Use different variables to accept the tokens?
There was a problem hiding this comment.
- Use different variables to accept the tokens?
As I said, define in schema for them, not directly use env vars. After you defined schema, you can set values by LISA vars, and then assign LISA vars by env vars.
Like you defined access_token in PlatformSchema. Please define similar tokens for other Azure scopes.
LiliDeng
force-pushed
the
lildeng/fix_12_25_003
branch
3 times, most recently
from
9c64209 to
7b135d5
Compare
LiliDeng
force-pushed
the
lildeng/fix_12_25_003
branch
from
7b135d5 to
fde8170
Compare
managed identity doesn't work with windows container directly for this reason
find a way to auth azure with access token