Added log for process input #3593
Open
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Jan 8, 2025
paulli2017
force-pushed
the
paull/process_log
branch
from
b5f7865 to
ba2dba6
Compare
|
@LiliDeng LGTM |
LiliDeng
reviewed
Jan 9, 2025
| if is_log_input: | ||
| self._log.debug(f"input content: {content}") | ||
| else: | ||
| self._log.debug(f"Inputting {len(content)} chars to process.") |
There was a problem hiding this comment.
Is the content of this if and else statement reversed?
There was a problem hiding this comment.
It's not, but please advise how to make the name clearer. The name means "is log input?" if it's true, log the input, if not just log the length of input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added process input log