Write test log for deployment failures #3596
Draft
+60
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
from
37abcb8 to
a4635e1
Compare
At present, test logs are not generated for deployment failures. This change creates case log for deployment failure with the failure reason.
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
from
a4635e1 to
a5dada8
Compare
adityagesh
commented
Jan 9, 2025
| self._log.info( | ||
| f"'{environment.name}' attached to test case " | ||
| f"'{result.runtime_data.metadata.full_name}({result.id_})': " | ||
| f"{exception}" | ||
| ) | ||
| result.save_nodes_serial_console_logs() |
There was a problem hiding this comment.
@squirrelsc , this doesn't work as environment.nodes is empty list
Shall I make _save_console_log_and_check_panic as a public method of Platform and then invoke platform.save_console_log(path=result.log_path)
lisa/lisa/sut_orchestrator/azure/platform_.py
Line 654 in 4b8bca8
There was a problem hiding this comment.
_attach_failed_environment_to_result is too late to attach log. What I mean is to attach log when this method is called in deploy/prepare methods. It can attach to the environment log, not the node log. env should be created already, and it includes all node logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, test logs are not generated for deployment failures. This change creates case log for deployment failure with the failure reason.