Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the JSON parsing to use a std::variant so there just a single OnValue handler vs OnString/OnNumber/OnBool/OnNull.
Previously a mismatched type would say
JSON Error: Unknown value: name at line 3 index 19
or it would say
JSON Error: Unknown value: name
if the name was known but the type of its value was wrong (example: #1146).
Now it'll give a much better error message, showing first the full path of the field being parsed, and then saying exactly how the types mismatch:
JSON Error: model:type - Expected a number but saw a string at line 3 index 19