New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize Objective-C bindings #709

Merged

skyline75489 merged 68 commits into microsoft:main from skyline75489:jialli/objc-bindings

Dec 12, 2024

Contributor

skyline75489 commented Jul 18, 2024 •

edited

Loading

This PR contains Objective-C wrapper code, podspec generation infras and the accompanying test code.

Internal workitem: https://task.ms/aii/35199

skyline75489 added 15 commits

July 9, 2024 14:20


          Init objc bindings

b339911


          Merge branch 'main' into jialli/objc-bindings

718e8d1


          More objc

1e14fa7

Fix

683daf5


          OGASpan

e77fb60


          More objc bindings

ad1c9e8


          license header

83d1273


          Update

d635d63


          Merge branch 'main' into jialli/objc-bindings

f4772b6


          Update folder structure


          format

fda89e8


          Rm podspec for now

844e7d5


          header

891ec8c


          more header

a4af1b5


          catch

fef5a1a

skyline75489 commented

View reviewed changes

src/objectivec/error_utils.h Show resolved Hide resolved

src/objectivec/oga_internal.mm Outdated Show resolved Hide resolved

src/objectivec/oga_internal.h Show resolved Hide resolved

skyline75489 added 4 commits

July 18, 2024 13:06


          Lint

cda7411


          Lint

edd86f6


          Lint

2eeb42c


          Lint

27d5494

natke requested review from skottmckay, edgchen1 and vraspar

July 18, 2024 18:34

edgchen1 reviewed

View reviewed changes

Contributor

edgchen1 left a comment

please document public APIs and add unit tests

skyline75489 added 3 commits

August 5, 2024 11:26


          Merge branch 'main' into jialli/objc-bindings

b904daf


          Merge branch 'main' into jialli/objc-bindings

616c1c5


          Merge branch 'main' into jialli/objc-bindings

0da29a6

skottmckay reviewed

View reviewed changes

src/objectivec/oga_generator_params.mm Outdated Show resolved Hide resolved

src/objectivec/oga_internal.mm Outdated Show resolved Hide resolved

src/objectivec/oga_internal.h Show resolved Hide resolved

src/objectivec/oga_tokenizer.mm Outdated Show resolved Hide resolved

src/objectivec/oga_tokenizer.mm Outdated Show resolved Hide resolved

skyline75489 added 2 commits

September 5, 2024 13:34


          save

808398a


          Merge branch 'main' into jialli/objc-bindings

ab6b20f


          getOutput

5b1e1ef

edgchen1 reviewed

View reviewed changes

src/objectivec/error_utils.mm Outdated Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/test/model_tests.mm Outdated Show resolved Hide resolved

src/objectivec/test/model_tests.mm Outdated Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/oga_internal.h Outdated Show resolved Hide resolved

src/objectivec/oga_sequences.mm Outdated Show resolved Hide resolved

src/objectivec/oga_sequences.mm Outdated Show resolved Hide resolved


          reviews

c9c31e3

edgchen1 reviewed

View reviewed changes

.pipelines/stages/jobs/macos-ios-cocoapods-packaging-job.yml Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/oga_tensor.mm Outdated Show resolved Hide resolved

src/objectivec/oga_tensor.mm Outdated Show resolved Hide resolved

src/objectivec/oga_tokenizer.mm Outdated Show resolved Hide resolved

tools/ci_build/github/apple/objectivec/objc.podspec.template Outdated Show resolved Hide resolved

src/objectivec/oga_internal.mm Outdated Show resolved Hide resolved

skyline75489 added 3 commits

October 28, 2024 11:58


          review

8d41739


          clang-format

7b068e8


          Merge branch 'main' into jialli/objc-bindings

9ac3518

edgchen1 reviewed

View reviewed changes

tools/ci_build/github/apple/c/c.podspec.template Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

edgchen1 reviewed

View reviewed changes

tools/ci_build/github/apple/test_apple_packages.py Show resolved Hide resolved

tools/ci_build/github/apple/package_assembly_utils.py Outdated Show resolved Hide resolved

skyline75489 added 4 commits

October 29, 2024 12:01


          reviews

094fb41


          Merge branch 'main' into jialli/objc-bindings

191bfe4


          sync main

48e4e11


          skip macos tests

0db23bf

edgchen1 reviewed

View reviewed changes

.pipelines/stages/jobs/steps/capi-appleframework-step.yml Outdated Show resolved Hide resolved

.pipelines/stages/jobs/macos-ios-cocoapods-packaging-job.yml Outdated Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/oga_internal.mm Outdated Show resolved Hide resolved

src/objectivec/test/ort_genai_api_test.mm Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/oga_images.mm Outdated Show resolved Hide resolved

src/objectivec/oga_named_tensors.mm Show resolved Hide resolved

src/objectivec/oga_internal.h Outdated Show resolved Hide resolved

src/objectivec/oga_multi_modal_processor.mm Outdated Show resolved Hide resolved

skyline75489 added 3 commits

November 28, 2024 15:05


          comments

1afacc9


          clang-format

d232230


          clang format

bd116dc

edgchen1 reviewed

View reviewed changes

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/test/ort_genai_api_test.mm Show resolved Hide resolved

src/objectivec/test/ort_genai_api_test.mm Show resolved Hide resolved

src/objectivec/test/ort_genai_api_test.mm Outdated Show resolved Hide resolved

skyline75489 and others added 2 commits

December 9, 2024 11:31


          Update src/objectivec/include/ort_genai_objc.h

9ffb63e

Co-authored-by: Edward Chen <[email protected]>


          Update src/objectivec/include/ort_genai_objc.h

1586fee

Co-authored-by: Edward Chen <[email protected]>

skyline75489 force-pushed the jialli/objc-bindings branch from d22088e to 1586fee Compare

December 9, 2024 05:19

skyline75489 added 2 commits

December 9, 2024 13:22


          reviews

af3cb02


          Reviews

8a3146b

edgchen1 reviewed

View reviewed changes

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/include/ort_genai_objc.h Outdated Show resolved Hide resolved

src/objectivec/oga_multi_modal_processor.mm Outdated Show resolved Hide resolved

skyline75489 and others added 2 commits

December 11, 2024 11:26


          Update src/objectivec/include/ort_genai_objc.h

2b15151

Co-authored-by: Edward Chen <[email protected]>


          Reviews

05ed250

edgchen1 approved these changes

View reviewed changes

Contributor

edgchen1 left a comment

looks good. thanks for adding the objective-c API!

skyline75489 merged commit 8e171c7 into microsoft:main

12 of 13 checks passed

This was referenced Dec 12, 2024

Added iOS testing infra & GHA job #964

Closed

Added iOS GHA pipeline #1148

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet