Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the ordering of cse and canonicalize passes for cse to be more efficient #205

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

parsifal-47
Copy link
Contributor

--cse before --canonicalize does not look optimal, but this is the original sequence from triton-to-linalg-experimental

@nhat-nguyen
Copy link
Collaborator

thank you! could we swap this ordering in triton-to-linalg-experimental instead?

@parsifal-47
Copy link
Contributor Author

thank you! could we swap this ordering in triton-to-linalg-experimental instead?

Sure, updated, please take a look, thank you!

@parsifal-47
Copy link
Contributor Author

I have updated LIT test to match new IR structure caused by different pass ordering

@nhat-nguyen
Copy link
Collaborator

just out of curiosity, do you know what the IR would look like if we run another canonicalization after cse? also we should update the PR title to reflect the new changes

@parsifal-47 parsifal-47 changed the title Switch off triton-to-linalg-experimental in compilation codepath Change the ordering of cse and canonicalize passes for cse to be more efficient Jan 4, 2025
@parsifal-47
Copy link
Contributor Author

just out of curiosity, do you know what the IR would look like if we run another canonicalization after cse? also we should update the PR title to reflect the new changes

That is a good question, I tried adding one more canonicalization and it did not change anything for our LIT test, so likely results are not very dramatic. PR title updated, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants