Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: Explicitly set allowBlobPublicAccess to false #1866

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

nturinski
Copy link
Member

Fixes microsoft/vscode-azurefunctions#4348

According to the SDK, this was always defaulted as false anyway

 /** Allow or disallow public access to all blobs or containers in the storage account. The default interpretation is false for this property. */
    allowBlobPublicAccess?: boolean;

But the new policy explicitly checks for it, I think. So we might as well set it just to be safe.

@nturinski nturinski requested a review from a team as a code owner January 8, 2025 23:38
@nturinski nturinski merged commit f132185 into main Jan 9, 2025
4 checks passed
@nturinski nturinski deleted the azure/nat/storageBlowPublicAccess branch January 9, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage blob public access needs to be disabled when creating a Function App
2 participants