refactor: Use .map in escapeCommandLine

microsoft · Jan 9, 2025 · 6b9cbea · 6b9cbea
1 parent 7b8c801
commit 6b9cbea
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/extensions/npm/src/tasks.ts b/extensions/npm/src/tasks.ts
@@ -297,15 +297,13 @@ export function getTaskName(script: string, relativePath: string | undefined) {
 }
 
 function escapeCommandLine(cmd: string[]): (string | ShellQuotedString)[] {
-	const result: (string | ShellQuotedString)[] = new Array(cmd.length);
-	for (let i = 0; i < cmd.length; i++) {
-		if (/\s/.test(cmd[i])) {
-			result[i] = { value: cmd[i], quoting: cmd[i].includes('--') ? ShellQuoting.Weak : ShellQuoting.Strong };
+	return cmd.map(arg => {
+		if (/\s/.test(arg)) {
+			return { value: arg, quoting: arg.includes('--') ? ShellQuoting.Weak : ShellQuoting.Strong };
 		} else {
-			result[i] = cmd[i];
+			return arg;
 		}
-	}
-	return result;
+	});
 }
 
 function getRelativePath(rootUri: Uri, packageJsonUri: Uri): string {