Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): minimize conditions in boolean context #8381

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 9, 2025

No description provided.

Copy link

graphite-app bot commented Jan 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Jan 9, 2025
Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #8381 will degrade performances by 16.79%

Comparing 01-09-feat_minifier_minimize_conditions_in_boolean_context (438a6e7) with main (e7c89ba)

Summary

❌ 1 regressions
✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 01-09-feat_minifier_minimize_conditions_in_boolean_context Change
minifier[typescript.js] 298.2 ms 358.3 ms -16.79%

@Boshen Boshen force-pushed the 01-09-feat_minifier_minimize_conditions_in_boolean_context branch 2 times, most recently from 0f01299 to 1b000d7 Compare January 9, 2025 15:29
@Boshen Boshen marked this pull request as ready for review January 9, 2025 15:29
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 9, 2025
Copy link
Member Author

Boshen commented Jan 9, 2025

Merge activity

  • Jan 9, 10:29 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 9, 10:46 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 9, 10:51 PM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 01-09-feat_minifier_minimize_conditions_in_boolean_context branch 4 times, most recently from 85ce9d7 to 77ca427 Compare January 10, 2025 03:40
@Boshen Boshen force-pushed the 01-09-feat_minifier_minimize_conditions_in_boolean_context branch from 77ca427 to 438a6e7 Compare January 10, 2025 03:47
@graphite-app graphite-app bot merged commit 438a6e7 into main Jan 10, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-09-feat_minifier_minimize_conditions_in_boolean_context branch January 10, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant