Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): fix static ui client types #7201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

userquin
Copy link
Member

@userquin userquin commented Jan 9, 2025

Description

The static module doesn't include the new rerunTask added to run individual tests in the new UI, and the openPromise not being initialized (Variable openPromise is used before being assigned.).

This PR also includes:

  • html reporter script in test/core and test/browser
  • add test/core/html and test/browser/html to .gitignore

We need to check why running the html reporter on test/browser doesn't generate the html folder, it is generating the app inside the test/browser folder.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant